Fix Popup positioning #1095
Merged
Fix Popup positioning #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/4.17.x |
✅ Backports have been created
|
saskliutas
approved these changes
Nov 5, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Fix _fitPopup of a Popup. * rush change * Fix tests (cherry picked from commit 091ea17)
GerardasB
added a commit
that referenced
this pull request
Nov 5, 2024
* Fix _fitPopup of a Popup. * rush change * Fix tests (cherry picked from commit 091ea17) Co-authored-by: GerardasB <[email protected]>
|
@Mergifyio backport release/5.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Fix _fitPopup of a Popup. * rush change * Fix tests (cherry picked from commit 091ea17)
GerardasB
added a commit
that referenced
this pull request
Nov 8, 2024
* Fix _fitPopup of a Popup. * rush change * Fix tests (cherry picked from commit 091ea17) Co-authored-by: GerardasB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR closes #1094 by fixing the positioning logic of a (deprecated) Popup component.
#719 will replace the Popup itself.
Testing
Tested manually via test-app.